chore(bestpractices): embed URLs inline + resolve SUGGESTED ? placeholders (RAN-52)#98
Merged
Merged
Conversation
…lders (RAN-52) Address the board's 04:35Z autofill diagnosis on RAN-52: bestpractices.dev's autofill flagged four URL-required criteria as "URL is requested but got text" even though `<key>_url` fields were present, plus two SUGGESTED criteria sitting at `?` placeholders. URL-required criteria — embed URL as the first token of `_justification` (in addition to keeping `<key>_url`, belt-and-suspenders so the autofill parser finds the URL no matter which field it reads): - contribution_requirements - release_notes (also adds CHANGELOG.md cross-reference) - report_archive - vulnerability_report_process SUGGESTED `?` → honest `Unmet` with rationale (non-blocking for `passing`): - dynamic_analysis — no DAST/fuzz pipeline; codeiq is a developer CLI binding `serve` to localhost. - dynamic_analysis_enable_assertions — `-ea` not force-enabled in CI test invocations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the board's 04:35Z autofill diagnosis on RAN-52 — six criterion fields where the bestpractices.dev autofill rejected the existing entries even though
<key>_urlfields were on disk.Fix 1 — embed URL inline at the start of
<key>_justification(4 MUST + 1 SHOULD)Belt-and-suspenders against whichever field the autofill parser reads. Keeps the existing
<key>_urlentries untouched.contribution_requirements_justification(SHOULD)release_notes_justification(MUST) — also adds aCHANGELOG.mdcross-reference now that PR #97 shipped itreport_archive_justification(MUST)vulnerability_report_process_justification(MUST)Fix 2 — resolve
?placeholders to honestUnmet(2 SUGGESTED)Both are SUGGESTED-tier so non-blocking for
passing, but the autofill flagged them as missing data. Better to be explicit:dynamic_analysis_status: "Unmet"— no DAST / fuzz pipeline; codeiq is a developer CLI bindingserveto localhost. Reconsidered when Java fuzzing (e.g. Jazzer) matures.dynamic_analysis_enable_assertions_status: "Unmet"—-eanot force-enabled in CI test invocations.Total diff: 8 insertions / 8 deletions on a single file. JSON parses clean (151 keys,
project_id: 12650,level: "passing").After this lands
Board re-clicks 🤖 on https://www.bestpractices.dev/projects/12650 → autofill picks up the inline URLs and the explicit
Unmetanswers → all six flagged criteria settle → expectingtiered_percentageto round up to 100% on the basics tier andbadge_level→passing.Test plan
chore/ran-52-bestpractices-url-fieldsbadge_levelflipsin_progress→passing🤖 Generated with Claude Code